Introduce RowBuilder to support writing basic unit tests #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added RowDescription trait, and let rows to share the same description rather than having a copy in each row (think when there are thousand of them in the result). Added RowBuilder to support adding stubs of row data in unit tests. Currently, the library users have no chooice but have to use integration tests for testing Postgres data access code. With the changes in this commit, the `tokio-postgres` lib users can use RowBuilder to create sutbs to verify the deserialization from database result (Rows) to custom stucts in unit tests. It can also serves as a base for future implementation of certain kind of mocks of the db connection. Related-to sfackler#910 sfackler#950
hunts
force-pushed
the
hunts/add-basic-testability-for-lib-users
branch
from
f712d07
to
07336e5
Compare
|
Hi @sfackler , I usually create a struct and implement Do you have any recommendation how to unit test conversions? |
|
I, too, need something like this for unit testing. |
|
I also need this, been watching the pr for a while, but seems like it's not going to be merged at all? |
|
Nothing to add except that the ability to synthesize Rows / a RowStream in unit testing is still very important to me. Is this something we can expect to ever see in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RowDescription trait, and let rows to share the same description rather than having a copy in each row (think when there are thousand of them in the result).
Added RowBuilder to support adding stubs of row data in unit tests.
Currently, the library users have no chooice but have to use integration tests for testing Postgres data access code. With the changes in this commit, the
tokio-postgreslib users can use RowBuilder to create sutbs to verify the deserialization from database result (Rows) to custom stucts in unit tests.It can also serves as a base for future implementation of certain kind of mocks of the db connection.
Related-to #910 #950