Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks Cmd-(Number) to switch between tabs #2

Open
galori opened this issue Oct 20, 2015 · 2 comments
Open

Breaks Cmd-(Number) to switch between tabs #2

galori opened this issue Oct 20, 2015 · 2 comments

Comments

@galori
Copy link

galori commented Oct 20, 2015

To reproduce:

  1. Install auto-reveal-active-file
  2. Open four tabs
  3. (You should be on Tab Unable to focus editor pane on Atom 1.17.0 (new dock feature) #4 now)
  4. Press Cmd-1, Cmd-2, Cmd-3, Cmd-4

Expected behavior:

The editor should jump between tabs 1, 2, 3 and 4

Observed behavior:

Only the first tab shows is displayed. 2, 3, and 4 are not.

Workaround / possible explanation:

I'm guessing this is the result of the focus being taken out of the editor. If I click in the editor between every tab switch it does work:

Cmd-1, (Click in the editor) Cmd-2, (Click in the editor) Cmd-3, (Click in the editor) Cmd-4 (Click in the editor)

@sfaedo
Copy link
Owner

sfaedo commented Oct 20, 2015

Fixed, please verify it on version 0.3.1 (this was working fine on Windows), it was the focus taken out of the editor

@galori
Copy link
Author

galori commented Dec 11, 2015

Thanks so much for looking at this.

It works for the first file, but doesn't work for subsequent files. As in:

  • Click on a file in the tree
  • now I can use Cmd-# to switch to another tab. 👍
  • However, after using Cmd-# to switch to a second tab, I can't use that again to switch to one more tab. (i.e. the focus correctly goes back to the editor after opening a file from the tree, but not after opening a file via Cmd-#)

Thanks again for looking at this. Yes this was not in Windows, this was in OSX. If you're a Windows user, double-thanks for looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants