Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code example fix #53

Merged
merged 3 commits into from Sep 10, 2018
Merged

Code example fix #53

merged 3 commits into from Sep 10, 2018

Conversation

nairihar
Copy link
Contributor

@nairihar nairihar commented Sep 7, 2018

Thanks for the nice library, just some minor fixes which I noticed when reading the documentation.

Line 65 add async function for await otherwise, it will not work.
Line 68 add quotes.
Line 366 throws error and server exit when the client sends a request. There is no need for next() function.

@artakvg
Copy link
Contributor

artakvg commented Sep 9, 2018

Thanks @nairihar jan for comments.
For the first 2 - I am ok with fixes.
For the 3-d one (removing next) I don't agree.
Think we should allow to run next() even if we send reply. @davidharutyunyan ?

@nairihar
Copy link
Contributor Author

nairihar commented Sep 9, 2018

But there is an error when you calling next() function

screen shot 2018-09-09 at 1 16 55 pm

@nairihar
Copy link
Contributor Author

nairihar commented Sep 10, 2018

I added back next function call instead I added the second handler for the same channel.
Also fixed spaces.

Copy link
Contributor

@davidharutyunyan davidharutyunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it's ok.

@davidharutyunyan davidharutyunyan merged commit d5507df into sfast:master Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants