Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

rake spec fails without ENV['SKIP_RAILS_ADMIN_INITIALIZER']='false' #1562

Closed
BM5k opened this Issue Mar 11, 2013 · 5 comments

Comments

Projects
None yet
3 participants

BM5k commented Mar 11, 2013

I understand why this exists and why it is set to true by default, however passing this environment variable when running rake spec is laughably horrible user experience.

IMNSHO, rails_admin should always load itself in test environment unless explicitly set.

BM5k commented Mar 11, 2013

For the record, adding ENV['SKIP_RAILS_ADMIN_INITIALIZER']='false' to the top of your spec_helper doesn't make the warning go away, but my specs pass.

Collaborator

bbenezech commented Mar 12, 2013

haha, never thought about that one. I just use rspec
Anyway we don't need it anymore because the model configurations being lazy loaded, the performance hit is negligible.

BM5k commented Mar 20, 2013

@bbenezech does that mean it will go away soon?

drags commented Aug 13, 2013

Just commented on #1362 as well, found via searching, but this probably belongs here more.

Please remove this line of output. This does not belong in STDOUT and having a gem which taints STDOUT like this is extremely bad.

This breaks the ability to confidently pipeline scripts or rake tasks in projects that use Rails Admin.

This muddles output to other code which expects the first line of output to be relevent to the code executed (for example: nagios monitoring tasks)

Especially if this code is no longer required, please kill it! At the very least this should be output to STDERR, since it is an error (warning) and not part of the users expected code output.

Collaborator

bbenezech commented Jan 22, 2014

fixed.

@bbenezech bbenezech closed this Jan 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment