Fix datetime parse logic #2448
Merged
Fix datetime parse logic #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalpo
force-pushed
the
feature/datetime-parse
branch
from
e169c00
to
8b4d4a7
Compare
|
Related to #2426 |
|
Spec is failing, any ideas? |
|
I will check soon! |
dalpo
force-pushed
the
feature/datetime-parse
branch
from
8b4d4a7
to
05deba5
Compare
|
@mshibuya Fixed and rebased from master but mongodb is still failing strangely... |
dalpo
force-pushed
the
feature/datetime-parse
branch
3 times, most recently
from
27a59ba
to
a978ba3
Compare
|
@mshibuya now specs are green! 🎆 |
dalpo
force-pushed
the
feature/datetime-parse
branch
from
a978ba3
to
e1410a9
Compare
Consider actual Timezone and the Daylight Saving Time while parsing datetime input parameters.
dalpo
force-pushed
the
feature/datetime-parse
branch
from
e1410a9
to
88cd2a5
Compare
|
@mshibuya let me know what do you think about this PR! Thanks |
|
Looks nice, thanks! |
This was referenced Nov 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider actual Timezone and the Daylight Saving Time while parsing datetime input parameters.