Update database cleaner to >= 2.0 #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, but dropping Ruby support can only be done in major releases. I've set the 3.0.0 milestone. |
|
I've made the master branch 3.0.0 ready. Could you rebase this to that? |
codealchemy
force-pushed
the
update-database-cleaner
branch
from
83929ec
to
f55d445
Compare
|
Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #3341
Related changes to
database_cleanergemdatabase_cleanerwas split into separate adapter gems - the two needed for this project are:database_cleaner-active_recorddatabase_cleaner-mongoidThis also removes Ruby 2.2 from the CI build, since
database_cleaneruses the safe navigation operator which was introduced in Ruby 2.3 (see related CI failure here). Maintaining a Ruby 2.2 build has caused issues elsewhere as well (see related discussion in #3256 (comment)), and 2.2 itself is no longer maintained as of March, 2018.