CI performance improvements #3383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable `bundler-cache` - ref: https://github.com/ruby/setup-ruby#caching-bundle-install-automatically Use `MAKE` env var to improve building native extensions on MRI - ref: https://build.betterup.com/one-weird-trick-that-will-speed-up-your-bundle-install/
|
Fantastic, thanks! |
codealchemy
added a commit
that referenced
this pull request
Jul 15, 2022
Followup to #3383 From discussion in ruby/setup-ruby#299 (comment) >setting flags in MAKE is not recommended, and it can break e.g. system ENV["MAKE"], "target". What works at least for GNU Make is to use MAKEFLAGS=-j8 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This skips the intermediate
Cache gems/Install dependenciessteps by enablingbundler-cachein thesetup-rubyaction.Additionally, the added
MAKEenv var improves the performance of building native extensions on MRI (borrowing the approach mentioned here)This up to roughly 1m30s per MRI build in the current CI matrix (and low-to-no improvement for
jrubybuilds)