Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current date doesn't take timezone into account #29

Closed
therefromhere opened this issue Apr 6, 2019 · 2 comments
Closed

Current date doesn't take timezone into account #29

therefromhere opened this issue Apr 6, 2019 · 2 comments
Assignees

Comments

@therefromhere
Copy link

Location.sun etc will default to the system date if it's not specified. I think it should take tz into account if local=True?

I hit this issue today in NZ, where the clocks just changed. Calculated dawn (etc) was off by 1 hour since the machine tz wasn't the same the location tz, therefore this morning the date was defaulting to yesterday, and therefore wasn't using daylight saving.

@sffjunkie
Copy link
Owner

In version 2.0 two functions have been added now and today which are timezone aware and are used where required e.g. in the Location class

@therefromhere
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants