Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ourddpg performance not good #35

Closed
ChenDRAG opened this issue Nov 18, 2020 · 4 comments
Closed

ourddpg performance not good #35

ChenDRAG opened this issue Nov 18, 2020 · 4 comments

Comments

@ChenDRAG
Copy link

ChenDRAG commented Nov 18, 2020

I run the source code of TD3: ourddpg algorithm and find performance in most games(apart from HalfCheetah-v3_0) is inconsistent with the original paper? Could you illustrate what might be the problem, please?
image
image

@sfujim
Copy link
Owner

sfujim commented Nov 30, 2020

I'll take a look at this, but noting that the versions have changed (python, pytorch, and mujoco), I'm not sure much can be said about a direct comparison with the original results any more.

@ChenDRAG
Copy link
Author

ChenDRAG commented Dec 27, 2020

Maybe it's because of hyperparameters? Could you specify the parameters used for ourddpg? Are those same as used in td3?

@johnnylin110
Copy link

I also want to ask the hyperparameters of ourddpg , and I follow the network and your hyperparameters in paper
image
and reproduce it in tensorflow version , which also got the bad result , is there any other hyperparameters different?
Like "Replay buffer size", and "start_timesteps" what hyperparameters are them when using our ddpg? are they the same as mention in paper? (start timesteps in Ant and Halfcheetah is 10000 and the other is 1000)

@sfujim
Copy link
Owner

sfujim commented Apr 6, 2021

Sorry for the delays! I've updated the hyperparameters to OurDDPG which should improve the performance. But in general if you want a good performance there's little reason not to use TD3, OurDDPG is just a baseline.

@sfujim sfujim closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants