Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support note names for opcodes, hikey, key, lokey and pitch_keycenter #620

Closed
SpotlightKid opened this issue Feb 2, 2021 · 3 comments · Fixed by #622
Closed

Support note names for opcodes, hikey, key, lokey and pitch_keycenter #620

SpotlightKid opened this issue Feb 2, 2021 · 3 comments · Fixed by #622

Comments

@SpotlightKid
Copy link

SpotlightKid commented Feb 2, 2021

Some software, for example Polyphone, produces SFZ files, where note names instead of MIDI note numbers are used for the values of the hikey, key, lokey and pitch_keycenter opcodes.

According to sfzformat.com: "values can be specified in MIDI note numbers (0-127) or note names (IPN Standard)". But the latter are currently not interpreted correctly by sfizz. It seems to just just play all the regions using these values on every key.

As a workaround, I currently use this script to fix the SFZ files exported by Polyphone (note that Polyphone also incorrectly uses partly localized note names, e.g. "H3" when the interface is not English, but that's a bug in Polyphone).

@jpcima
Copy link
Collaborator

jpcima commented Feb 2, 2021

Can you possibly share a sample?
Polyphone does not export me IPN notes, my output has numbers.

@kinwie
Copy link

kinwie commented Feb 2, 2021

@jpcima there is an option to choose note names instead of numbers. It's like in the Setting or Option menu

@jpcima
Copy link
Collaborator

jpcima commented Feb 2, 2021

Ok so this amounts to support the unicode symbols ♯ and ♭.
Sure I'll add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants