Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change function arguments for MIDI channel to zero-based #8

Closed
SpotlightKid opened this issue Nov 29, 2019 · 2 comments
Closed

Change function arguments for MIDI channel to zero-based #8

SpotlightKid opened this issue Nov 29, 2019 · 2 comments
Assignees

Comments

@SpotlightKid
Copy link

SpotlightKid commented Nov 29, 2019

Currently the channel argument for the sfizz_send_* functions uses 1-based counting of MIDI channels.

I suggest changing this to zero-based counting, i.e. 0-15, since this is how the channel is represented in the MIDI status byte and how most software stores and passes it internally.

IMO, 1-based counting should only be used when presenting a MIDI channel number to the user.

@paulfd
Copy link
Member

paulfd commented Dec 3, 2019

Agreed!

@paulfd
Copy link
Member

paulfd commented Dec 9, 2019

Should be ok on develop as of c6a9ba8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants