Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8 check to enforce style #53

Merged
merged 1 commit into from Nov 7, 2019
Merged

Add flake8 check to enforce style #53

merged 1 commit into from Nov 7, 2019

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Nov 6, 2019

  • Update code as required to pass default flake8 check
  • Remove requirements.txt, as these were only recommended for development
  • Unfix pydocstyle version to allow pip to install the latest release
  • Move code/docstyle checks before pytests

@mwtoews
Add flake8 check to enforce style
139f2a0 
* Update code as required to pass default flake8 check
* Remove requirements.txt, as these were only recommended for development
* Unfix pydocstyle version to allow pip to install the latest release
* Move code/docstyle checks before pytests
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 139f2a0 on mwtoews:flake8 into e90718c on sgillies:master.

sgillies
sgillies approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@sgillies sgillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thanks for reminding me about dedent, I just thought of another place to use it.

@sgillies sgillies added this to the 3.0 milestone Nov 7, 2019
@sgillies sgillies merged commit 1aec93e into rasterio:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgillies sgillies sgillies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mwtoews @coveralls @sgillies