Communes by dep #47
Merged
Communes by dep #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jdesboeufs |
|
Quelle honte. -1.2%, pire que le CAC 40. |
| @@ -178,6 +178,33 @@ paths: | |||
| schema: | |||
| $ref: '#/definitions/Error' | |||
|
|
|||
| /departements/{code}/communes: | |||
| get: | |||
| summary: Renvoi les communes du d'un département | |||
|
Better? @jdesboeufs |
| @@ -83,11 +83,19 @@ app.get('/departements/:code', initDepartementFields, function (req, res) { | |||
| }); | |||
|
|
|||
| app.get('/departements/:code/communes', initCommuneFields, initCommuneFormat, function (req, res) { | |||
| let communes = dbCommunes.queryByDep(req.params.code); | |||
| if (!communes) { | |||
| let departement = dbDepartements.queryByCode(req.params.code)[0]; | |||
There was a problem hiding this comment.
Si le résultat est vide, tu vas avoir une exception et donc une erreur 500.
Ça veut dire qu'il manque un test d'intégration avec la 404 attendue.
const matching = dbDepartements.queryByCode(req.params.code);
if (match.length === 0) {
res.sendStatus(404);
} else {
const departement = matching[0];
/// ...
}Enfin dans l'esprit quoi.
There was a problem hiding this comment.
Ou du coup :
if (dbDepartements.queryByCode(req.params.code) === 0) {
// Booom
} else {
// Good
}
added 3 commits
June 17, 2016 19:10
|
Last one? @jdesboeufs |
| @@ -83,11 +83,10 @@ app.get('/departements/:code', initDepartementFields, function (req, res) { | |||
| }); | |||
|
|
|||
| app.get('/departements/:code/communes', initCommuneFields, initCommuneFormat, function (req, res) { | |||
| let departement = dbDepartements.queryByCode(req.params.code)[0]; | |||
| if (!departement) { | |||
| let communes = dbCommunes.queryByDep(req.params.code); | |||
There was a problem hiding this comment.
On ne s'est pas compris.
On cherche à vérifier l'existence du département, pas qu'il contienne des communes.
|
Il manque la recherche standard, à savoir via |
|
Fix #28 |
|
Fini. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Réf #31