Remove positional params for component feedback-panel

betagouv · Apr 11, 2017 · 87aaec7 · 87aaec7
1 parent b7466cb
commit 87aaec7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/live/app/components/feedback-panel.js b/live/app/components/feedback-panel.js
@@ -5,10 +5,11 @@ const FORM_CLOSED = 'FORM_CLOSED';
 const FORM_OPENED= 'FORM_OPENED';
 const FORM_SUBMITTED = 'FORM_SUBMITTED';
 
-const FeedbackPanel = Ember.Component.extend({
+export default Ember.Component.extend({
 
   store: Ember.inject.service(),
 
+  answer: null,
   email: '',
   content: '',
   error: null,
@@ -50,11 +51,4 @@ const FeedbackPanel = Ember.Component.extend({
       this.set('status', FORM_CLOSED);
     }
   }
-
-});
-
-FeedbackPanel.reopenClass({
-  positionalParams: ['answer']
 });
-
-export default FeedbackPanel;
diff --git a/live/app/templates/components/comparison-window.hbs b/live/app/templates/components/comparison-window.hbs
@@ -58,7 +58,7 @@
       {{#if isAssessmentChallengeTypeQcu}}
           {{qcu-solution-panel challenge=challenge answer=answer solution=solution}}
       {{/if}}
-      
+
       {{#if isAssessmentChallengeTypeQroc}}
         <div class="comparison-window__corrected-answers comparison-window__corrected-answers--qroc">
           {{qroc-solution-panel answer=answer solution=solution }}
@@ -69,7 +69,7 @@
 
     <div class="routable-modal--footer">
       <div class="comparison-window__feedback-panel">
-        {{feedback-panel answer}}
+        {{feedback-panel answer=answer}}
       </div>
     </div>
   </div>

diff --git a/live/tests/integration/components/feedback-panel-test.js b/live/tests/integration/components/feedback-panel-test.js
@@ -31,7 +31,7 @@ function expectMercixViewToBeVisible(component) {
   expect(component.$(MERCIX_VIEW)).to.have.length(1);
 }
 
-describe('Integration | Component | feedback-panel', function () {
+describe.only('Integration | Component | feedback-panel', function () {
 
   setupComponentTest('feedback-panel', {
     integration: true