protecting inputs from airtable

betagouv · Dec 8, 2016 · d3d3b23 · d3d3b23
1 parent 383c195
commit d3d3b23
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/api/lib/domain/services/solution-service-qrocm-dep.js b/api/lib/domain/services/solution-service-qrocm-dep.js
@@ -2,6 +2,19 @@ const utils = require('./solution-service-utils');
 const yaml = require('js-yaml');
 const _ = require('lodash');
 
+// We expect that parsing from airtable returns an Object
+// whose all values are array, like this :
+// { Google: [ 'Google', 'google.fr', 'Google Search' ], Yahoo: [ 'Yahoo', 'Yahoo Answer' ] }
+function _isValidSolution(solution) {
+  let result = false;
+  if (_.isObject(solution)) {
+    result = _.every(solution, function(item) {
+      return _.isArray(item) && _.every(item, (e) => _.isString(e));
+    });
+  }
+  return result;
+}
+
 module.exports = {
 
   match (yamlAnswer, yamlSolution) {
@@ -16,6 +29,10 @@ module.exports = {
       // solution is
       // { Google: [ 'Google', 'google.fr', 'Google Search' ], Yahoo: [ 'Yahoo', 'Yahoo Answer' ] }
 
+      if (!_isValidSolution(solution)) {
+        return result;
+      }
+
       const possibleAnswers = {};
       _.each(solution, (answerList, solutionKey) => {
         _.each(answerList, (answer) => {