test added (after review-

betagouv · Dec 21, 2016 · efceac8 · efceac8
1 parent c5b524e
commit efceac8
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/api/lib/domain/services/solution-service-qrocm-dep.js b/api/lib/domain/services/solution-service-qrocm-dep.js
@@ -73,9 +73,9 @@ module.exports = {
       const minGrade = _.min(Object.keys(scoring));
       const maxGrade = _.max(Object.keys(scoring));
 
-      if(numberOfUniqueCorrectAnswers >= maxGrade) {
+      if (numberOfUniqueCorrectAnswers >= maxGrade) {
         result = 'ok';
-      } else if(numberOfUniqueCorrectAnswers >= minGrade) {
+      } else if (numberOfUniqueCorrectAnswers >= minGrade) {
         result = 'partially';
       }
 

diff --git a/api/tests/unit/utils/lodash-utils_test.js b/api/tests/unit/utils/lodash-utils_test.js
@@ -46,4 +46,36 @@ describe('Unit | Utils | lodash-utils', function () {
       done();
     });
   });
+
+
+  describe('ensureString', function () {
+    it('when no input, return an empty String', function (done) {
+      expect(_.ensureString()).to.equal('');
+      done();
+    });
+    it('when input is explicitly undefined, return an empty String', function (done) {
+      expect(_.ensureString(undefined)).to.equal('');
+      done();
+    });
+    it('when input is explicitly null, return an empty String', function (done) {
+      expect(_.ensureString(null)).to.equal('');
+      done();
+    });
+    it('when input is a number (typeof meaning), it returns a JSON.stringify version of the input', function (done) {
+      expect(_.ensureString(42)).to.equal('42');
+      done();
+    });
+    it('when input is a string (typeof meaning), it returns a JSON.stringify version of the input', function (done) {
+      expect(_.ensureString('42')).to.equal('42');
+      done();
+    });
+    it('when input is an object (typeof meaning), it returns a JSON.stringify version of the input', function (done) {
+      expect(_.ensureString(/[aeiou]+/g)).to.equal('/[aeiou]+/g');
+      done();
+    });
+    it('when input is an boolean (typeof meaning), it returns a JSON.stringify version of the input', function (done) {
+      expect(_.ensureString(true)).to.equal('true');
+      done();
+    });
+  });
 });