[#346] [FEATURE] Afficher la comparaison des résultats pour un QCU (US-321). #346

florianEnoh · 2017-03-15T15:32:14Z

Create qcu solution-component, add qcu-solution to mirage, and fix tests

coveralls · 2017-03-15T17:14:55Z

Coverage increased (+0.1%) to 93.671% when pulling 59605c0 on 321-qcu-solution-panel into 2b636df on dev.

jbuget · 2017-03-15T17:15:11Z

I've deployed this PR to http://321-qcu-solution-panel.pix.beta.gouv.fr. Please check it out

coveralls · 2017-03-16T18:49:55Z

Coverage increased (+0.1%) to 93.671% when pulling 9363ca3 on 321-qcu-solution-panel into 2b636df on dev.

jbuget · 2017-03-16T18:50:13Z

I've deployed this PR to http://321-qcu-solution-panel.pix.beta.gouv.fr. Please check it out

coveralls · 2017-03-16T22:47:45Z

Coverage increased (+0.1%) to 93.679% when pulling bd0a3df on 321-qcu-solution-panel into 2b636df on dev.

jbuget · 2017-03-16T22:48:03Z

I've deployed this PR to http://321-qcu-solution-panel.pix.beta.gouv.fr. Please check it out

coveralls · 2017-03-17T10:15:57Z

Coverage increased (+0.1%) to 93.679% when pulling 0295c63 on 321-qcu-solution-panel into 2b636df on dev.

jbuget · 2017-03-17T10:16:09Z

I've deployed this PR to http://321-qcu-solution-panel.pix.beta.gouv.fr. Please check it out

MBrandone · 2017-03-21T09:46:51Z

live/app/styles/components/qcu-solution-panel.scss

+  position: relative;
+  cursor: pointer;
+}
+


On a déjà essayé de régler ce XXX rapidement ?
Je sais pas si c'est vraiment un XXX

Ici on fait détourne les règles, il est important de justifier

MBrandone · 2017-03-21T09:49:03Z

live/app/templates/components/qcu-solution-panel.hbs

+<div class="qcu-panel__proposals rounded-panel">
+  <div class="rounded-panel__row qcu-panel__proposal-list">
+    {{#each labeledRadios as |labeledItemRadio index|}}
+      <p class="qcu-panel__proposal-item">


Est-ce-qu'on a vraiment besoin de ces commentaires dans le html ?

Pour le coup même moi ça m'aide

C'est viré

MBrandone · 2017-03-21T09:51:06Z

live/mirage/config.js

@@ -14,7 +14,7 @@ import postFeedbacks from './routes/post-feedbacks';
 import postRefreshSolution from './routes/post-refresh-solution';



a quoi sert ce this.logging ?

Il sert à désactiver les logs de mirage, qu'on utilise quasiment pas

coveralls · 2017-03-22T13:48:54Z

Coverage increased (+0.2%) to 93.699% when pulling 39c90ad on 321-qcu-solution-panel into 2b636df on dev.

jbuget · 2017-03-22T13:49:11Z

I've deployed this PR to http://321-qcu-solution-panel.pix.beta.gouv.fr. Please check it out

coveralls · 2017-03-22T14:32:25Z

Coverage increased (+0.2%) to 93.726% when pulling 58ca1db on 321-qcu-solution-panel into 2b636df on dev.

jbuget · 2017-03-22T14:32:39Z

I've deployed this PR to http://321-qcu-solution-panel.pix.beta.gouv.fr. Please check it out

coveralls · 2017-03-22T15:09:52Z

Coverage increased (+0.2%) to 93.726% when pulling 4550a3b on 321-qcu-solution-panel into 2b636df on dev.

jbuget · 2017-03-22T15:10:15Z

I've deployed this PR to http://321-qcu-solution-panel.pix.beta.gouv.fr. Please check it out

coveralls · 2017-03-22T16:17:31Z

Coverage increased (+0.09%) to 93.85% when pulling 87ef483 on 321-qcu-solution-panel into f402cd8 on dev.

jbuget · 2017-03-22T16:17:43Z

I've deployed this PR to http://321-qcu-solution-panel.pix.beta.gouv.fr. Please check it out

jbuget

Il faut (re-)supprimer la tâche "install:all" qui ne sert vraiment plus à rien (ou alors il y a un problème)

jbuget · 2017-03-22T17:52:44Z

package.json

@@ -27,6 +30,7 @@
    "clean": "node_modules/.bin/run-p clean:api clean:live clean:coverage",
    "install:api": "cd api && npm install",
    "install:live": "cd live && npm install",
+    "install:all": "npm install && node_modules/.bin/run-p install:api install:live",


non, il ne faut plus cette ligne ! elle a été proprement remplacée par l'ajout de la tâche postinstall et prise en compte dans CircleCI

Je viens de faire le test en virant la ligne mais CI bug automatiquement parce qu'il veut utiliser cette instruction.
Je pense qu'après le merge ça va mettre ce qui va bien.

coveralls · 2017-03-23T10:56:18Z

Coverage increased (+0.09%) to 93.85% when pulling 8a91470 on 321-qcu-solution-panel into f402cd8 on dev.

jbuget · 2017-03-23T10:56:32Z

I've deployed this PR to http://321-qcu-solution-panel.pix.beta.gouv.fr. Please check it out

its Ok

Create qcu solution-component, add qcu-solution to mirage, and fix tests

3cb876d

florianEnoh changed the title ~~[#][FEATURE] afficher la comparaison des résultats pour un qcu~~ [#346][FEATURE] afficher la comparaison des résultats pour un qcu Mar 15, 2017

florianEnoh added [Tech] Review asked [Func] Review asked labels Mar 15, 2017

jbuget added [Tech] Changes validated and removed [Tech] Review asked labels Mar 15, 2017

Fix refSolution data

59605c0

jbuget added 6 commits March 16, 2017 16:32

Fix bug

96c93bd

Try to fix CircleCI builds

aa5efc4

New attempt to fix CircleCI builds

2578b7a

New attempt to fix CircleCI builds

126d657

New attempt to fix CircleCI builds

f876cb7

New attempt to fix CircleCI builds

9363ca3

jbuget changed the title ~~[#346][FEATURE] afficher la comparaison des résultats pour un qcu~~ [#346] [FEATURE] afficher la comparaison des résultats pour un qcu Mar 16, 2017

jbuget changed the title ~~[#346] [FEATURE] afficher la comparaison des résultats pour un qcu~~ [#346] [FEATURE] Afficher la comparaison des résultats pour un QCU (US-321). Mar 16, 2017

jbuget removed the [Tech] Changes validated label Mar 16, 2017

jbuget added 2 commits March 16, 2017 23:28

Add unit tests for comparison-window

7e158ba

Refactor comprison-window

bd0a3df

Remove Ember run from qcu-solution-test

0295c63

Florian added 3 commits March 17, 2017 11:39

Refacto qcm-solution-panel test

b682978

Refacto qcm-solution integration test variables

038504b

Refacto qcu-solution-panel-test test sentences

6009e41

jbuget added [Func] Review asked and removed [Func] Review asked labels Mar 20, 2017

MBrandone reviewed Mar 21, 2017

View reviewed changes

Refacto eq helper and add tests

39c90ad

Florian added 2 commits March 22, 2017 15:14

Add or helper

61e54b8

Refacto qcu solution panel ok and fix eq helper test

58ca1db

Florian added 2 commits March 22, 2017 15:36

Refacto qcm-solution in progress

0ceee78

Refacto qcm-solution-panel

4550a3b

florianEnoh and others added 3 commits March 22, 2017 16:25

Merge branch 'dev' into 321-qcu-solution-panel

ebd58b6

Delete useless spaces

920e0bb

Improve node version

87ef483

jbuget previously requested changes Mar 22, 2017

View reviewed changes

Florian added 2 commits March 23, 2017 11:48

delete useless line in package.json

8138618

delete useless line in package.json

8a91470

florianEnoh merged commit 17212fa into dev Mar 23, 2017

florianEnoh deleted the 321-qcu-solution-panel branch March 23, 2017 15:35

mackwic added this to the no-milestone milestone Dec 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#346] [FEATURE] Afficher la comparaison des résultats pour un QCU (US-321). #346

[#346] [FEATURE] Afficher la comparaison des résultats pour un QCU (US-321). #346

florianEnoh commented Mar 15, 2017

coveralls commented Mar 15, 2017

jbuget commented Mar 15, 2017

coveralls commented Mar 16, 2017

jbuget commented Mar 16, 2017

coveralls commented Mar 16, 2017

jbuget commented Mar 16, 2017

coveralls commented Mar 17, 2017

jbuget commented Mar 17, 2017

MBrandone Mar 21, 2017

florianEnoh Mar 21, 2017

MBrandone Mar 21, 2017

florianEnoh Mar 21, 2017

florianEnoh Mar 22, 2017

MBrandone Mar 21, 2017

florianEnoh Mar 21, 2017

coveralls commented Mar 22, 2017

jbuget commented Mar 22, 2017

coveralls commented Mar 22, 2017

jbuget commented Mar 22, 2017

coveralls commented Mar 22, 2017

jbuget commented Mar 22, 2017

coveralls commented Mar 22, 2017

jbuget commented Mar 22, 2017

jbuget left a comment

jbuget Mar 22, 2017

florianEnoh Mar 23, 2017 •

edited

Loading

coveralls commented Mar 23, 2017

jbuget commented Mar 23, 2017

		@@ -14,7 +14,7 @@ import postFeedbacks from './routes/post-feedbacks';
		import postRefreshSolution from './routes/post-refresh-solution';

[#346] [FEATURE] Afficher la comparaison des résultats pour un QCU (US-321). #346

[#346] [FEATURE] Afficher la comparaison des résultats pour un QCU (US-321). #346

Conversation

florianEnoh commented Mar 15, 2017

coveralls commented Mar 15, 2017

jbuget commented Mar 15, 2017

coveralls commented Mar 16, 2017

jbuget commented Mar 16, 2017

coveralls commented Mar 16, 2017

jbuget commented Mar 16, 2017

coveralls commented Mar 17, 2017

jbuget commented Mar 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Mar 22, 2017

jbuget commented Mar 22, 2017

coveralls commented Mar 22, 2017

jbuget commented Mar 22, 2017

coveralls commented Mar 22, 2017

jbuget commented Mar 22, 2017

coveralls commented Mar 22, 2017

jbuget commented Mar 22, 2017

jbuget left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

florianEnoh Mar 23, 2017 • edited Loading

Choose a reason for hiding this comment

coveralls commented Mar 23, 2017

jbuget commented Mar 23, 2017

florianEnoh Mar 23, 2017 •

edited

Loading