This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
[#414][CLEANUP] Epurer la palette de couleur #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianEnoh
changed the title
…b.com/sgmap/pix into santize-color-palette-with-color-name
|
I've deployed this PR to http://santize-color-palette-with-color-name.pix.beta.gouv.fr. Please check it out |
MBrandone
reviewed
May 16, 2017
| max-width: 449px; | ||
| width: 100%; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .signup-form__temporary-msg h4{ | ||
| .signup-form__temporary-msg h4 { | ||
| border-radius: 3px; |
MBrandone
reviewed
May 16, 2017
| } | ||
|
|
||
| .signup-textfield__message--error.signup-textfield__message-password,.signup-textfield__message--error.signup-textfield__message-email { | ||
| .signup-textfield__message--error.signup-textfield__message-password, .signup-textfield__message--error.signup-textfield__message-email { | ||
| position: relative; |
There was a problem hiding this comment.
2 fois position : relative
MBrandone
reviewed
May 16, 2017
| background-image: none; | ||
| text-decoration: none; | ||
| display: inline-block; | ||
| border: 1px solid; | ||
| box-shadow: 0 1px 1px -1px $grey3; | ||
| box-shadow: 0 1px 1px -1px $oslo-grey; | ||
| } | ||
|
|
||
| .button-primary:hover, | ||
| .button-primary:focus { | ||
| color: #fff; |
There was a problem hiding this comment.
color en caractère juste au-dessus
MBrandone
reviewed
May 16, 2017
| background-image: none; | ||
| text-decoration: none; | ||
| display: inline-block; | ||
| border: 1px solid; | ||
| box-shadow: 0 1px 1px -1px $grey3; | ||
| box-shadow: 0 1px 1px -1px $oslo-grey; | ||
| } | ||
|
|
||
| .button-secondary:hover, | ||
| .button-secondary:focus { | ||
| color: #fff; |
There was a problem hiding this comment.
color en caractère juste au-dessus
|
LGTM modulo BSR sur les couleurs encore écrites en hexa |
|
I've deployed this PR to http://santize-color-palette-with-color-name.pix.beta.gouv.fr. Please check it out |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette tâche a consisté à :
Pour trouver les noms de couleurs à partir de leurs codes hex, deux sites ont été utilisés :