Updates README with updated backgroundEffect #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous README was a bit outdated and the instructions for backgroundEffect said pullToDismiss?.background instead of pullToDismiss?.backgroundEffect, which confused me so I took a look at the source code and corrected the mistake in case anybody else uses this and is confused
|
I read your contribution guidelines and decided to use a pull request instead of posting an issue because this wasnt really a change to the source code. This is really a minor correction for the README, thanks again for providing this repo and open sourcing it. Really like it and was a bit confused with outdated README, had to look inside source code to figure it out. Thanks again! 👍 |
|
Just noticed this is going towards master branch, going to close for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous README was a bit outdated and the instructions for backgroundEffect said pullToDismiss?.background instead of pullToDismiss?.backgroundEffect, which confused me so I took a look at the source code and corrected the mistake in case anybody else uses this and is confused
Updates the README to what current source code for PullToDismiss.swift looks like