Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #146

Closed
zefir-git opened this issue Nov 20, 2022 · 2 comments
Closed

Improve documentation #146

zefir-git opened this issue Nov 20, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@zefir-git
Copy link

zefir-git commented Nov 20, 2022

The README.md (presumably the documentation for this project) lacks essential information for the usage of this software.

The options are not defined. Instead, you have a link to the source code. However, the link is not a permalink tied to a specific commit. In any case, reading the source to try to understand how to use it is not enjoyable. This is also the case for styling and almost everything else.

/**
* Outline used to scale and centralize the projection in the chart area.
* By default a sphere is used
* @default { type: 'Sphere" }
*/
outline: any[];

Except for {type: "sphere"}, what other options can be passed? Type any[] does not particularly help me understand.

Well-formed documentation would be most welcome.

@zefir-git zefir-git added the enhancement New feature or request label Nov 20, 2022
@sgratzl sgratzl closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2023
@zefir-git
Copy link
Author

@sgratzl No comment?

@contis2908
Copy link

I agree with @zefir-git. I am having a hard time understanding the examples too.
First of all the provided codepen doesn't show any imports so I have to manually look into the installed package and find the exports.
Secondly, the examples provided on GitHub https://github.com/sgratzl/chartjs-chart-geo/blob/main/docs/examples/bubbleMap.ts do import things but from my understanding, these should be part of your package import { Feature, topojson } from '../../src';

The codepen uses ChartGeo.topojson so I usually would figure that is what I need to import. However, this is not part of your export and on top, it throws a TS error that it now requires GeoFeature.

Overall I find this to be quite confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants