Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception messages and get rid of custom exceptions #64

Open
ocefpaf opened this issue Oct 22, 2015 · 0 comments
Open

Improve exception messages and get rid of custom exceptions #64

ocefpaf opened this issue Oct 22, 2015 · 0 comments

Comments

@ocefpaf
Copy link
Member

ocefpaf commented Oct 22, 2015

I don't see the need for the custom exceptions we have here,

https://github.com/sgrid/pysgrid/blob/master/pysgrid/custom_exceptions.py

They add an unnecessary extra complexity layer and they are a burden to maintainers. In the end all those exceptions are ValueErrors.

Also, we need to mimic pyugrid messages and return what is failing instead of just failing.

PS: I just fixed a dataset thanks to pyugrid's messages saying what variables where missing or in a non-compliant form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ocefpaf