Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hint produces an unwanted attribute #92

Closed
collimarco opened this issue Mar 31, 2015 · 3 comments
Closed

hint produces an unwanted attribute #92

collimarco opened this issue Mar 31, 2015 · 3 comments

Comments

@collimarco
Copy link
Contributor

= f.password_field :current_password, required: true, hint: 'We need your current password to confirm your changes.'

Produces:

<label for="user_current_password" class="">Current password</label><input type="password" hint="We need your current password to confirm your changes." required="required"><span class="hint">We need your current password to confirm your changes.</span>

As you can see there's an unwanted hintattribute on the input.

I think the expected behavior is only to produce the span element.

@collimarco
Copy link
Contributor Author

Fixed via #96

@dsandstrom
Copy link
Collaborator

Thanks for PRs. I'll merge them this weekend if not earlier.

@collimarco
Copy link
Contributor Author

#96 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants