Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding colormap functionality #17

Merged
merged 6 commits into from Aug 2, 2022
Merged

Adding colormap functionality #17

merged 6 commits into from Aug 2, 2022

Conversation

odedstein
Copy link
Collaborator

Adding a function "colormap" that works like MATLAB's colormap, and then also "apply_colormap" to apply the colormap to a scalar function.
I was not sure what exact interpolation behavior to choose for "apply_colormap", but MATLAB does piecewise constant, so I went with piecewise constant.

@sgsellan
Copy link
Owner

sgsellan commented Aug 2, 2022

I made a few minor changes. Maybe most important for standardization is that I changed the docstrings to better fit (my interpretation of) the numpy standard. I think I'd rather be strict about the standard unless we have a good reason to deviate from it. Feel free to revert if you have any strong feelings about this.

I also removed the dependency on matplotlib from our setup file and installation builds, and added some checks to the unit tests.

If you're happy, I'll merge after checks

@sgsellan sgsellan merged commit be47722 into sgsellan:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants