Make the forced_update of @cached and @memoize accept the same parameters as the decorated function #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh4nks
requested changes
May 29, 2019
flask_caching/__init__.py
Outdated
| """Check if the function wants any arguments | ||
| """ | ||
|
|
||
| try: |
There was a problem hiding this comment.
Now that Python 2 is removed, I guess we can simplify this now?
flask_caching/__init__.py
Outdated
| @@ -390,7 +413,7 @@ def decorated_function(*args, **kwargs): | |||
| args, kwargs, use_request=True | |||
| ) | |||
|
|
|||
| if callable(forced_update) and forced_update() is True: | |||
| if callable(forced_update) and (forced_update(*args, **kwargs) if wants_args(forced_update) else forced_update()) is True: | |||
There was a problem hiding this comment.
The line is a bit to long. I'd like to keep the line length to 80.
I am using black to keep my python files nicely formatted (we gotta add this to our not yet existing CONTRIBUTING file :P)
gergelypolonkai
force-pushed
the
forced-update-parameters
branch
from
9b4a683
to
6ec5aa3
Compare
|
I think i fixed everything we talked about. Also, finally we have a coverage increase! 😄 |
sh4nks
approved these changes
May 30, 2019
sh4nks
reviewed
May 30, 2019
gergelypolonkai
force-pushed
the
forced-update-parameters
branch
from
6ec5aa3
to
eba5f72
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112