Remove Python 2 support #116
Conversation
gergelypolonkai
force-pushed
the
remove-python2
branch
2 times, most recently
from
0c51a50
to
95c4e4d
Compare
gergelypolonkai
force-pushed
the
remove-python2
branch
from
95c4e4d
to
9a3c69c
Compare
gergelypolonkai
force-pushed
the
remove-python2
branch
from
9a3c69c
to
88b758d
Compare
|
I fixed what you asked for, and the tests still run fine. the coverage change looks strange, but looking it the numbers it didn’t actually change (the same amount of code lines are covered as before, we just lost some previously tested code. |
There was a problem hiding this comment.
I made travis work with Python 3.7 here: https://github.com/flaskbb/flaskbb/blob/7b869949d9fb0c13bd0c12c79d556be7da2eba30/.travis.yml
But we can handle this in a separate PR :-)
flask_caching/backends/base.py
Outdated
| @@ -13,7 +10,7 @@ def iteritems_wrapper(mappingorseq): | |||
|
|
|||
| """ | |||
| if hasattr(mappingorseq, "items"): | |||
| return iteritems(mappingorseq) | |||
| return iter(mappingorseq.items()) | |||
There was a problem hiding this comment.
In Python 3, items() returns an iterator and not a list --> iter is not needed here
There was a problem hiding this comment.
Yes, that was suspicious for me, i just couldn’t wrap my head around it early in the morning i guess.
flask_caching/backends/memcache.py
Outdated
| @@ -97,7 +97,7 @@ def get_dict(self, *keys): | |||
| d = rv = self._client.get_multi(_keys) | |||
| if have_encoded_keys or self.key_prefix: | |||
| rv = {} | |||
| for key, value in iteritems(d): | |||
| for key, value in iter(d.items()): | |||
There was a problem hiding this comment.
iter(d.items()) --> d.items()
gergelypolonkai
force-pushed
the
remove-python2
branch
from
88b758d
to
2a8a8aa
Compare
|
There, everything is fixed. Take a look and merge when you see fit. |
gergelypolonkai
force-pushed
the
remove-python2
branch
from
2a8a8aa
to
0203c02
Compare
|
Everything looks good now! Thanks! |
No description provided.