Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__init__.py fails to consider operating system when setting base_app_folder #10

Closed
ghost opened this issue Oct 31, 2014 · 0 comments
Closed

Comments

@ghost
Copy link

ghost commented Oct 31, 2014

init.py:185 sets the variable base_app_folder to the application's root_path, splitting out any / characters to get only the last directory's name. However, windows uses \ to denote directories, which causes importlib to fail when it encounters a full path.

When the split character is set to "", everything else works fine -- either init.py should detect operating system and change the character accordingly, or a more robust mechanism for detecting the root directory should be built (os.path might help abstract this).

EDIT: I'm an idiot, looks like this was fixed a month ago, and is pushed in v1.5. I'll close this now; keep up the good work :)

@ghost ghost closed this as completed Oct 31, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants