Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog #441

Merged
merged 1 commit into from Apr 9, 2018
Merged

Update changelog #441

merged 1 commit into from Apr 9, 2018

Conversation

justanr
Copy link
Collaborator

@justanr justanr commented Apr 7, 2018

Sampling of the changelog, we should look through merged PRs and see if there's anything else that needs to be added.

As an aside, do we want to investigate towncrier for managing release notes?

@justanr justanr added this to the 2.0 milestone Apr 7, 2018
@justanr justanr requested a review from sh4nks April 7, 2018 23:01
@justanr justanr mentioned this pull request Apr 7, 2018
7 tasks
@sh4nks
Copy link
Member

sh4nks commented Apr 9, 2018

Thanks for writing the changelog! I've never heard of towncrier - do you have any experience with it?

Copy link
Member

@sh4nks sh4nks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you covered the last missing pieces

@sh4nks sh4nks merged commit bc64e93 into flaskbb:master Apr 9, 2018
@justanr
Copy link
Collaborator Author

justanr commented Apr 9, 2018

I don't have experience with towncrier, I know it works by reading snippets out of a news directory and generates a changelog based on that. I took a look at aiohttp's usage and it seems straightforward but I haven't used it myself.

Alternatively, we could request changelog entries on PRs.

It's kind of six on one hand, half a dozen in the other

@justanr justanr deleted the ensure-changelog branch July 17, 2018 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants