Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When setting up a dev version of core, the behat/mink-browserkit-driver dependency is upgraded to an incompatible version. #140

Open
1 of 3 tasks
codebymikey opened this issue Jan 4, 2024 · 0 comments

Comments

@codebymikey
Copy link

Describe the bug

At the time of writing, core is pinned to "behat/mink-browserkit-driver": "v2.1.0"

However, when setting up the gitpod, the .gitpod/drupal/install-essential-packages.sh script runs

ddev . composer require --dev "drupal/core-dev":* "phpspec/prophecy-phpunit":^2 -W --no-install

which inadvertently upgrades behat/mink-browserkit-driver to an incompatible version of v2.2.0, which breaks tests such as:

ddev phpunit core/modules/block/tests/src/Functional/BlockTest.php --filter testBlockVisibility

Because core currently passes boolean values to the form, whereas it now strictly checks for strings.

Expected behavior

Core dependencies should be pinned to whatever version it's expected to via a drupal/core-dev-pinned:^11 type-dependency in the root composer.json, or we need to find a way to add those phpspec/prophecy-phpunit dependencies without upgrading normal packages.

Version and configuration information (please complete the following information)

Additional context

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant