Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a file with contribution guidelines #154

Closed
nodiscc opened this issue Mar 7, 2015 · 3 comments · Fixed by #223
Closed

Create a file with contribution guidelines #154

nodiscc opened this issue Mar 7, 2015 · 3 comments · Fixed by #223
Assignees
Milestone

Comments

@nodiscc
Copy link
Member

nodiscc commented Mar 7, 2015

Followup to #146

Maybe it'd help if we created a file with contribution guidelines about issue management, pull request/code review, etc. for the project.

Related resources:

There are infos to gather about general management trends scattered in various issue reports (open and closed). List them here and we'll add them. Anything I post here can be discussed/edited.

@nodiscc
Copy link
Member Author

nodiscc commented Mar 7, 2015

Documentation

the wiki is world-writable - anyone can edit or add chapters and pages.

  • Large changes should preferably be discussed in General discussion beforehand (you can post a draft there and edit it).
  • If you create a new page, please link it from the new page (eg from the Other links section.
  • The wiki is a general documentation about Shaarli: usage, development, hacks, usage tricks, related links, projects. Try to keep it organized.
  • The wiki will be synced to Shaarli's doc/ directory on each release. Keep that in mind when reviewing the quality of your edits.

You can make the project known by publishing blog posts/articles/videos about it and adding them to the links section in the wiki.

Translations

Currently Shaarli has no translation/internationalization/localization system available and is single-language. You can help by proposing an i18n system (issue #121)

@nodiscc
Copy link
Member Author

nodiscc commented Mar 7, 2015

Bugs and feature requests

Reporting bugs, feature requests: issues management

You can look through existing bugs/requests and help reporting them here.

Constructive input/experience reports/helping other users is welcome.

The general guideline of the fork is to keep Shaarli simple (project and code maintenance, and features-wise), while providing customization capabilities (plugin system, making more settings configurable).

Check the milestones to see what issues have priority.

  • The issues list should preferably contain only tasks that can be actioned immediately. Anyone should be able to open the issues list, pick one and start working on it immediately.
  • If you have a clear idea of a feature you expect, or have a specific bug/defect to report, search the issues list, both open and closed to check if it has been discussed, and comment on the appropriate issue. If you can't find one, please open a new issue
  • General discussions fit in [archived] General discussion #44 so that we don't follow a slope where users and contributors have to track 90 "maybe" items in the bug tracker. Separate issues about clear, separate steps can be opened after discussion.
  • You can also join instant discussion at https://gitter.im/shaarli/Shaarli, or via IRC as described here

@nodiscc
Copy link
Member Author

nodiscc commented Mar 31, 2015

Beta testing

You can help testing Shaarli releases by immediately upgrading your installation after a new version has been releases.

All current development happens in Pull Requests. You can test proposed patches by cloning the Shaarli repo, adding the Pull Request branch and git checkout to it. You can also merge multiple Pull Requests to a testing branch.

git clone https://github.com/shaarli/Shaarli
git remote add pull-request-25 owner/cool-new-feature
git remote add pull-request-26 anotherowner/bugfix
git remote update
git checkout -b testing
git merge cool-new-feature
git merge bugfix

Please report any problem you might find.

Contributing code

Adding your own changes

  • Pick or open an issue
  • Fork the Shaarli repository on github
  • git clone your fork
  • starting from branch master, switch to a new branch (eg. git checkout -b my-awesome-feature)
  • edit the required files (from the Github web interface or your text editor)
  • add and commit your changes with a meaningful commit message (eg Cool new feature, fixes issue #1001)
  • Open your fork in the Github web interface and click the "Compare and Pull Request" button, enter required info and submit your Pull Request.

All changes you will do on the my-awesome-feature in the future will be added to your Pull Request. Don't work directly on the master branch, don't do unrelated work on your my-awesome-feature branch.

Contributing to an existing Pull Request

TODO

Useful links

If you are not familiar with Git or Github, here are a few links to set you on track:

@nodiscc nodiscc self-assigned this Jun 9, 2015
@nodiscc nodiscc modified the milestones: 0.9beta, 1.0 Jun 9, 2015
@nodiscc nodiscc added the easy good place to start contributing label Jun 9, 2015
@virtualtam virtualtam modified the milestones: 0.9.0, 0.5.0 Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants