Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark::fromArray does not save custom data set by plugins on save_link #1808

Open
Kdecherf opened this issue Oct 16, 2021 · 1 comment
Open
Labels
bug it's broken! help-wanted help-wanted plugin bells and whistles
Milestone

Comments

@Kdecherf
Copy link

The new Bookmark object and its service introduced in v0.12 remove custom data set by save_link plugin hooks.

This behavior has two drawbacks:

  1. All custom data set when saving new links are lost (e.g. with the provided demo_plugin)
  2. All custom data set on links saved with previous versions of Shaarli are lost when updateMethodMigrateDatabase is executed

Bookmark::fromArray() should support a custom key to let plugins add again custom data.

Example of plugins saving custom data on links: via

@nodiscc nodiscc added bug it's broken! plugin bells and whistles labels Dec 17, 2021
@nodiscc nodiscc added this to the backlog to the future milestone Jun 18, 2022
@nodiscc
Copy link
Member

nodiscc commented Nov 15, 2023

Related (or duplicate?) #2000

@nodiscc nodiscc added the help-wanted help-wanted label Nov 30, 2023
@nodiscc nodiscc modified the milestones: backlog to the future, 0.14.0 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug it's broken! help-wanted help-wanted plugin bells and whistles
Projects
None yet
Development

No branches or pull requests

2 participants