Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move QR code as a plugin #57

Closed
nodiscc opened this issue Nov 10, 2014 · 1 comment
Closed

Move QR code as a plugin #57

nodiscc opened this issue Nov 10, 2014 · 1 comment
Labels
cleanup code cleanup and refactoring plugin bells and whistles
Milestone

Comments

@nodiscc
Copy link
Member

nodiscc commented Nov 10, 2014

The QR code should be optional (as well as archive.org and readityourself integration), even if it's enabled by default (should it?).

Once #52 is tested and merged, we can use the plugin system to move the QR code to tpl/plugins/qrcode/. This plugin will require 2 parts:

  • The HTML elment <div style="position:relative;display:inline;"><a href="http://qrfree.kaywa.com/?l=1&s=8&d=urlencodedlink" onclick="showQrCode(this); return false;" class="qrcode" data-permalink="url of link"><img src="images/qrcode.png" width="13" height="13" title="QR-Code"></a></div> - can be injected in the linklist using LINKLIST_PLUGINS
  • The script itself <script language="JavaScript"> // Remove any displayed QR-Code function remove_qrcode() [...] can be injected in the page footer using a new FOOTER_PLUGINS option

Optional QR code requested at sebsauvage#171

@nodiscc nodiscc added plugin bells and whistles cleanup code cleanup and refactoring labels Nov 10, 2014
This was referenced Nov 10, 2014
@nodiscc nodiscc added this to the 0.9beta milestone Dec 2, 2014
@nodiscc nodiscc mentioned this issue Dec 19, 2014
@nodiscc
Copy link
Member Author

nodiscc commented Mar 18, 2015

This is part of #164. Please help reviewing the Pull Request, taking ideas in #14 and #106 into account so we can anticipate what's needed for a useful plugin system.

@nodiscc nodiscc closed this as completed Mar 18, 2015
@virtualtam virtualtam modified the milestones: 0.9.0, 0.5.0 Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup and refactoring plugin bells and whistles
Projects
None yet
Development

No branches or pull requests

2 participants