Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doesn't work with dplyr 0.8.2 #7

Closed
shabbychef opened this issue Jul 3, 2019 · 2 comments
Closed

doesn't work with dplyr 0.8.2 #7

shabbychef opened this issue Jul 3, 2019 · 2 comments
Assignees
@shabbychef

Comments

@shabbychef
Copy link
Owner

should have tried before submitting, but the app is broken now. something to do with %in% in filters or mutates makes it very very slow.
@shabbychef shabbychef self-assigned this Jul 3, 2019
@shabbychef shabbychef mentioned this issue Jul 3, 2019
Closed
@shabbychef
Copy link
Owner Author

I think this is entirely due to a performance regression in dplyr, but I should rearrange the ingredient filtering code to be more efficient under 'sane' dplyr.

@shabbychef
Copy link
Owner Author

shabbychef commented Jul 7, 2019 •
edited

fixed by dplyr 0.8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shabbychef shabbychef

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shabbychef