Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aio with Anys #25

Closed

Conversation

slessans
Copy link

@slessans slessans commented Dec 7, 2021

This attempts to fix some of the asyncio issues by converting metadata to Anys. Not particularly proud of the solution, but may be an OK band-aid in the meantime if it can get things unblocked. All the rest of the code is the original code from #15

@slessans slessans closed this Dec 7, 2021
@slessans slessans reopened this Dec 7, 2021
@slessans slessans changed the title [DRAFT] Fix aio with Anys Fix aio with Anys Dec 7, 2021
@slessans slessans marked this pull request as ready for review December 7, 2021 20:08
@shabbyrobe
Copy link
Owner

Thanks again for picking this up. I'm definitely keen to see this sorted out too, great to see some progress!

In my response to issue #20, I hoped you might be able to provide some representative usage snippets:

[...] Would you mind sharing a couple of representative, anonymised, ideally self-contained snippets with me here? That will make it much easier for me to get up and running and also give me some ready-made use cases to try to target with some tests.

Having already had to revert this particular feature once before due to quality issues, I'm reluctant to merge anything without quite a few of these snippets turned into test cases. Even if it's just snippets in comments here, then I can add tests myself, I don't mind. But I do want to be much more careful to minimise potential disruption this time, as this is by no means a trivial addition and I'm concerned that I'm not using this feature enough myself at the moment to be able to get the nuance right.

@shabbyrobe
Copy link
Owner

shabbyrobe commented Apr 16, 2022

Closed due to inactivity. Feel free to reopen with MREs any time.

@shabbyrobe shabbyrobe closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants