-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mailtracker issues #52
Comments
I will start working on that last issue and connect mailaddresses to accounts.. |
Heyo,
Ooch, this is worrying. I wasn't aware of this limitation, and I'm not sure about how it should be handled :/ TextField does makes sense because message-ids have no size limitations, and actually, postgresql doesn't make much of a difference between text and charfields. What fix would you suggest ?
That's it
I guess it needs a separate issue and further diagnosis. It's probably due to an unfortunate regression during development, or IMAP madness
I know that's weird, but that's absolutely intended !
If you add end up implementing this, can you add the corresponding setting ? It was implemented this way for multiple reasons:
Thanks for testing ! |
@multun Iam just diving into the |
@ezzra that's sort of it ! this code is about properly handling mail threads. It's not used to create a mail tree inside django-todo, but it just takes in account the tree-like structure of mail threads when considering where incoming emails should go to. There are two separate things going on here:
A full mail threading algorithm looks like that. We aren't anywhere close, fortunately. |
I still don't see the problem or any benefit here. Maybe I don't understand your workflow. In the end, regardless if you take I expect users just to answer to the comment notification, which will send an email to the server with something like |
I think so, but I'll do my best to make it clearer.
Because it's not always within the headers. The task_id is only there when answering an email notification. If the tracker is suscribed to a mailing list, all threads will be separate tasks, each answer being a comment. In this case, there are no notifications involved at all !
That's not the only usecase: somebody may send an email to the tracker, get no notification at all (just like your regular contact@company.com), somebody may answer that same email, and as long as the tracker gets the answer too, it'll get attached back to the task. The mail tracker isn't just about enabling email notification answers. It's about tracking any email. If you want to add knobs to restrict the scope of what it can do, please do, it sounds like a useful thing ! |
I see that I have a different usecase at all for the todo tool. I wont use it in way as a client helpdesk, more like the github issue system and the email notification and answering feature is just an easy way so people do not have to login before adding a task or reacting to comments. And I want to keep it simple, thats why I chose the tool in the first way. So I guess I will need to fork this for my own approaches. |
@ezzra I would suggest adding a feature flag to make it fit what you want. The patch probably is under 10 lines, and the existing code was designed to be very modular. The internet doesn't need one more fork, the simple way is the unified way. If you create one more fork:
The existing code can already do that, and since comments can't be edited for now, being logged in doesn't change anything. I guess you miss the following features:
The existing code just needs the few lines of glue required to do that. If you don't want to plug into the existing tracker thing, well, you can create another consumer and use it ! Just add a file in there, and here you go. All the added features are optionnal, and I did my best to keep it simple. I know this feature isn't for everybody. That's why if you don't do anything, no (almost?) additionnal code runs. |
@ezzra - @multun and I had quite a bit of back-and-forth during code review about the same issue you raised - that anyone knowing the email addr can successfully post a task or comment into the system, and the spam possibilities that arise from that. I was very reluctant to allow that to happen. Multun convinced me that, in a way, the "support" queue is really just shadowing an email address, and anyone can already write to any email address on the internet without proving themselves first. And I get the need for a feature like this to exist in an org doing public support, especially with multiple people doing support / sharing a mailbox. That said, I can see the need to add features/settings for disabling this aspect of the system, or for blocking spammy sender addresses (but beware - it would be all too easy to get into the zillion hassles of email spam handling). I think a specific issue for that feature should be opened if you feel you need it, rather than this generic "Mailtracker issues" thread. Also note that todo has long supported the general concept of letting unauthenticated users post support issues. This Mailtracker feature is much more than that. Important to keep their use cases conceptually separated. |
Of course Iam totally aware of the disadvantages of forking, but I do depend on the advantages.
edit: ok should not be true, got an error once but did not try to find out where it comes from, should actually not happen because of |
@ezzra A PR is in and almost merged for the MySQL compatibility issue. Based on the discussion above, are there any other items from your original list that you feel still need to be addressed? (I'll want to make a separate ticket for each, or you can). If not, I'd like to close this. Thanks for the helpful feedback! |
Closing this for now, but would love to hear confirmation from your or another mysql user that all is well with the 2.3 upgrade on mysql. And feel free to open individual tickets if any of your issues in the OP still need addressing. Contributions always welcome! |
first, thank you very much for the new mailtracking feature, I just wanted to start working on such a feature :)
But some issues came up for me:
Comment.email_message_id
toCharField
and remake migrations, because mysql cannot useTextField
as key and throws an error.TextField
does not make sense here by the way?!preserve=false
setting does not work for me, emails are not deletedTODO_MAIL_BACKENDS
first confused me, until I realised that they are not necessary for the mailtracking feature, its just that you can now have seperate email configs for each list, correct?The text was updated successfully, but these errors were encountered: