Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactComponentClass not work for external components #336

Closed
Katrix opened this issue Mar 2, 2020 · 1 comment · Fixed by #377
Closed

ReactComponentClass not work for external components #336

Katrix opened this issue Mar 2, 2020 · 1 comment · Fixed by #377
Labels
bug
Milestone
v0.6.6

Comments

@Katrix
Copy link

Katrix commented Mar 2, 2020

As the title says.
@shadaj shadaj added the bug label Apr 10, 2020
@shadaj
Copy link
Owner

shadaj commented Apr 10, 2020

This is definitely behavior that should be supported and shouldn't be too hard to implement, so I've assigned this to the next milestone. Thanks for the report @Katrix!

In the meantime, ReactComponentClass is just a native JS type so you can grab the .component of the external component and just cast.

@shadaj shadaj added this to the v0.6.6 milestone Apr 10, 2020
shadaj added a commit that referenced this issue May 30, 2020
@shadaj
Allow exporting external components to ReactComponentClass instances
36aad5f 
Fixes #336
@shadaj shadaj mentioned this issue May 30, 2020
Merged
shadaj added a commit that referenced this issue May 31, 2020
@shadaj
Allow exporting external components to ReactComponentClass instances (
fa93d14 
#377)

Fixes #336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.6.6
Development

Successfully merging a pull request may close this issue.

Allow exporting external components to ReactComponentClass instances shadaj/slinky
2 participants
@shadaj @Katrix