Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop treating archive names as hashes #8

Closed
ShadelessFox opened this issue Jan 20, 2022 · 0 comments
Closed

Stop treating archive names as hashes #8

ShadelessFox opened this issue Jan 20, 2022 · 0 comments
Assignees
Labels
bug Something isn't working xg: hzd Issues related to Horizon: Zero Dawn xp: high Issues with high priority

Comments

@ShadelessFox
Copy link
Owner

DS uses MurmurHash3 of the original archive name, HZD uses human-readable archive names.

This causes problems when creating hash ⇔ archive mappings:

hashToArchive.put(Long.reverseBytes(Long.parseUnsignedLong(hash, 0, 16, 16)), archive);

There's no purpose in having such mappings. Archives must be referenced by their original name.

To provide human-readable names for DS, we could create an external file with mappings and use it from the UI part only.

@ShadelessFox ShadelessFox added bug Something isn't working xp: high Issues with high priority xg: hzd Issues related to Horizon: Zero Dawn labels Jan 20, 2022
@ShadelessFox ShadelessFox self-assigned this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working xg: hzd Issues related to Horizon: Zero Dawn xp: high Issues with high priority
Projects
None yet
Development

No branches or pull requests

1 participant