Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compilation of SkyBox.ps.slang fails #100

Closed
nbentyNV opened this issue Jul 15, 2017 · 6 comments
Closed

Cross-compilation of SkyBox.ps.slang fails #100

nbentyNV opened this issue Jul 15, 2017 · 6 comments
Labels
kind:bug something doesn't work like it should

Comments

@nbentyNV
Copy link
Collaborator

nbentyNV commented Jul 15, 2017

The last statement in the Slang file is
return gTexture.Sample(gSampler, normalize(dir), 0);

Which is converted to the following illegal statement in GLSL
gTexture.Sample(gSampler, normalize(dir), float(0));

To reproduce run the Effects/EnvMap sample

@tangent-vector-personal

Thanks. That should be an easy fix.

@tangent-vector-personal

Note to self: hopefully just missing some __intrinsic(glsl, ...) modifiers in the stdlib.

@tangent-vector tangent-vector self-assigned this Jul 18, 2017
@nbentyNV
Copy link
Collaborator Author

Not an issue anymore. I was about to fix it and then I noticed that what I really want to use is SampleLevel. It works (but we still need to add the missing flavors)

@tangent-vector
Copy link
Contributor

Cool. Let's leave this open so I can get to it sooner or later.

@tangent-vector tangent-vector removed their assignment Jul 18, 2017
@tangent-vector
Copy link
Contributor

Note to self: the "sample with clamp" operations seem to be a GLSL extension (sparse textures, IIRC), and not something built-in. If we need these they will have to be tagged to enable the right extension.

@tangent-vector tangent-vector changed the title Corss-compilation of SkyBox.ps.slang fails Cross-compilation of SkyBox.ps.slang fails Aug 15, 2017
@tangent-vector tangent-vector added kind:bug something doesn't work like it should cross compilation labels Oct 11, 2017
@tangent-vector
Copy link
Contributor

Closing. We are far past this point in cross-compilation support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug something doesn't work like it should
Projects
None yet
Development

No branches or pull requests

3 participants