Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro Expansion Bug #2134

Closed
WeakKnight opened this issue Feb 17, 2022 · 4 comments · Fixed by #3942
Closed

Macro Expansion Bug #2134

WeakKnight opened this issue Feb 17, 2022 · 4 comments · Fixed by #3942
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should priority:high required for next milestone
Milestone
Q2 2024 (Spring)

Comments

@WeakKnight
Copy link

WeakKnight commented Feb 17, 2022 •
edited
Loading

image
image

MESSY_PAD(3) is expanded to uint3 padVar11 but it should be uint3 padVar14.
@jsmall-zzz
Copy link
Contributor

Can confirm this is a problem. It appears to be taking __LINE__from the macro definition rather than from the macro expansion point.

@tangent-vector
Copy link
Contributor

I can try to take this one. It would be helpful to get a sense of timeline and/or urgency.

@tangent-vector tangent-vector self-assigned this Feb 18, 2022
@WeakKnight
Copy link
Author

WeakKnight commented Feb 19, 2022 •
edited
Loading

For me it is not very urgent. I currently use something like PAD(number, __LINE__) as a workaround instead of PAD(number).

@tangent-vector tangent-vector added kind:bug something doesn't work like it should area:preprocessor priority:high required for next milestone labels Apr 13, 2022
@natduca
Copy link

natduca commented Dec 1, 2023

Developer breakage, Q2 low, Q3 medium

@natduca natduca added this to the Q2 2024 (Spring) milestone Dec 1, 2023
@swoods-nv swoods-nv added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Feb 22, 2024
This was referenced Apr 12, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should priority:high required for next milestone
Projects
None yet
Milestone
Q2 2024 (Spring)
Development

Successfully merging a pull request may close this issue.

Fix micro expansion issue for __LINE__. csyonghe/slang
5 participants
@natduca @tangent-vector @WeakKnight @jsmall-zzz @swoods-nv