Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/cpu-program/gfx-smoke.slang causes slang compiler to assert #3953

Closed
tgrimesnv opened this issue Apr 15, 2024 · 4 comments · Fixed by #4079
Closed

tests/cpu-program/gfx-smoke.slang causes slang compiler to assert #3953

tgrimesnv opened this issue Apr 15, 2024 · 4 comments · Fixed by #4079
Assignees
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should

Comments

@tgrimesnv
Copy link
Collaborator

Using the command line for slang-test:
tests/cpu-program/gfx-smoke -use-test-server -server-count 1

Gives this:
error: ERROR:
EXPECTED{{{
result code = 0
standard error = {
}
standard output = {
0.0
1.0
2.0
3.0
}
}}}
ACTUAL{{{
result code = -1
standard error = {
(0): error 99999: Slang compilation aborted due to an exception of class Slang::InternalError: assert failure: modifiers.isEmpty()
}
standard output = {
}
}}}

FAILED test: 'tests/cpu-program/gfx-smoke.slang (cpu)'

===
0% of tests passed (0/1)

failing tests:

tests/cpu-program/gfx-smoke.slang (cpu)

@tgrimesnv tgrimesnv added the kind:bug something doesn't work like it should label Apr 15, 2024
@jkwak-work
Copy link
Collaborator

This is regression caused from

commit c28a22fb8b505ff48ca0814ca290ee4f698aa38b
Author: Yong He <yonghe@outlook.com>
Date:   Wed Mar 20 13:33:13 2024 -0700

    Fix namespace parsing. (#3803)

    * Fix namespace parsing.

    * Fix.

It works if I revert the change.

@jkwak-work jkwak-work added this to the Q2 2024 (Spring) milestone Apr 15, 2024
@swoods-nv swoods-nv added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Apr 17, 2024
@bmillsNV
Copy link
Collaborator

@tgrimesnv can you please summarize where we are at with this issue?

@tgrimesnv
Copy link
Collaborator Author

This would be a question for @csyonghe

@bmillsNV
Copy link
Collaborator

Not an urgent issue for now. We'll put this back on the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang kind:bug something doesn't work like it should
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants