Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow's epoll and poll don't support EPOLLERR and EPOLLHUP #2181

Open
stevenengler opened this issue May 24, 2022 · 0 comments
Open

Shadow's epoll and poll don't support EPOLLERR and EPOLLHUP #2181

stevenengler opened this issue May 24, 2022 · 0 comments
Labels
Type: Enhancement New functionality or improved design

Comments

@stevenengler
Copy link
Contributor

stevenengler commented May 24, 2022

Events for poll and epoll include EPOLLHUP/POLLHUP and EPOLLERR/POLLERR to indicate hang up / error conditions on files. Shadow currently only supports EPOLLIN and EPOLLOUT for level-triggered events, so it does not correctly indicate these hang up / error conditions.

We also need better tests for these conditions, and for the behaviour of select(). I think sometimes a file where epoll would return EPOLLHUP and not EPOLLIN will still appear in the readfds list for select().

@stevenengler stevenengler added the Type: Bug Error or flaw producing unexpected results label May 24, 2022
@stevenengler stevenengler added Type: Enhancement New functionality or improved design and removed Type: Bug Error or flaw producing unexpected results labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New functionality or improved design
Projects
None yet
Development

No branches or pull requests

1 participant