Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test flakiness due to hard-coded ports #718

Closed
sporksmith opened this issue Feb 7, 2020 · 3 comments · Fixed by #709
Closed

Test flakiness due to hard-coded ports #718

sporksmith opened this issue Feb 7, 2020 · 3 comments · Fixed by #709
Assignees

Comments

@sporksmith
Copy link
Contributor

Some tests open a listening socket on a hard-coded port number. While these are fine when running under Shadow, when we run them on the native host those ports may not be available, causing the test to fail.

@sporksmith
Copy link
Contributor Author

Pull request #709 fixes some, but not all, of these.

@sporksmith sporksmith linked a pull request Feb 7, 2020 that will close this issue
@sporksmith sporksmith added bug and removed support labels Feb 7, 2020
@sporksmith sporksmith self-assigned this Feb 7, 2020
@sporksmith
Copy link
Contributor Author

sporksmith commented Apr 23, 2020

#763 (particularly e4900a5) demonstrates a way of doing this for multi-process tests. Outside of Shadow, we can use a fifo to pass the port number from the server process to the client process.

Unfortunately fifo's don't currently work properly under Shadow, but it's OK to use hard-coded ports under Shadow, since they should be reliably available there. i.e. the tests can take a command-line parameter either specifying a hard-coded port (for use when running under Shadow), or a path to a fifo to use to communicate the port.

@sporksmith
Copy link
Contributor Author

I think #787 took care of the rest of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant