Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recipes): no page query string for first page #1140

Merged
merged 12 commits into from May 30, 2020

Conversation

shadow81627
Copy link
Owner

No description provided.

@vercel
Copy link

vercel bot commented May 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/damienrobinson/pocketpasta/diyej68jg
✅ Preview: https://pocketpasta-git-fixrecipes-no-page-query-string-for-first-page.damienrobinson.now.sh

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #1140 into master will increase coverage by 1.68%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
+ Coverage   51.95%   53.63%   +1.68%     
==========================================
  Files          36       36              
  Lines         256      261       +5     
  Branches       33       35       +2     
==========================================
+ Hits          133      140       +7     
+ Misses        123      121       -2     
Impacted Files Coverage Δ
pages/recipes/_id/index.vue 57.14% <0.00%> (-9.53%) ⬇️
pages/recipes/index.vue 45.45% <0.00%> (-4.55%) ⬇️
components/Recipe/Recipe.vue 100.00% <100.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 919b85e...cf246fc. Read the comment docs.

@shadow81627
Copy link
Owner Author

shadow81627 commented May 29, 2020

@vercel vercel bot temporarily deployed to Preview May 29, 2020 12:07 Inactive
@shadow81627 shadow81627 merged commit d1ee733 into master May 30, 2020
shadow81627 pushed a commit that referenced this pull request May 30, 2020
  ## [0.32.4](v0.32.3...v0.32.4) (2020-05-30)

### Bug Fixes

- **recipes:** no page query string for first page ([#1140](#1140)) ([d1ee733](d1ee733))
@shadow81627
Copy link
Owner Author

🎉 This PR is included in version 0.32.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@shadow81627 shadow81627 deleted the fix(recipes)--no-page-query-string-for-first-page branch May 30, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant