Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dust Effects - Broken in KSP 1.4 #55

Closed
shadowmage45 opened this issue Mar 16, 2018 · 3 comments
Closed

Dust Effects - Broken in KSP 1.4 #55

shadowmage45 opened this issue Mar 16, 2018 · 3 comments

Comments

@shadowmage45
Copy link
Owner

Due to KSP switching to shuriken particle system.

Unsure how viable this will be for a replacement, if it will even be usable.

@blowfishpro
Copy link
Contributor

blowfishpro commented Mar 16, 2018

SmokeScreen transitioned a while back without much trouble it seems. Might also be worth contacting sarbian for advice on this.

@shadowmage45
Copy link
Owner Author

From a brief look at the ParticleSystem API -- the conversion will be doable, but massively painful. Basically going to be a complete rewrite of the DustEffects system, as precisely zero of the existing code can be used by the new system.

Also going to have to create my own particle textures, as I was previously using some SQUAD particle prefabs, which are obviously not going to work (or likely even exist) in the new versions). Seems like a good opportunity to define a unique secondary effect to use for the water 'splash' stuff as well (or possibly multiple effects).

In the short-term I'm likely going to disable the existing dust-effects code entirely to resolve the current NRE issues reported on the forums, and push out an updated release with the dust disabled.

Will aim to have the rewritten system back in place 'in a few weeks'. Sadly, I really do have more important things to fix in other mods (e.g. TU has some bad breakage, and SSTU is entirely broken at the moment).

@shadowmage45
Copy link
Owner Author

Wow.. the syntax for using the new particle system is absolutely atrocious. Its like Unity actively hates their customers and wants them to die in a fire or something.

Every.... single.... property change has to be wrapped using an extra variable to pull out their asinine 'struct module' garbage.

What should be a simple 'set property to X'
particleSystem.emission.enabled = false

Instead has to be implemented like so:

var emissionModule = particleSystem.emission;
emissionModule.enabled = false;

Now try doing that across a couple hundred lines of code that adjust particle properties. Utter trash. I hate Unity more every day....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants