Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move third-party code to git submodules #1087

Closed
Mygod opened this issue Jan 17, 2017 · 2 comments
Closed

Move third-party code to git submodules #1087

Mygod opened this issue Jan 17, 2017 · 2 comments
Labels
enhancement

Comments

@Mygod
Copy link

Mygod commented Jan 17, 2017

When I was developing simple-obfs-android, it's painful to see there's too many duplicated codes between this one and simple-obfs, especially the third-party code. Please move them to git submodules for easier maintaining as in shadowsocks-android. Thanks.
@madeye
Copy link

madeye commented Jan 18, 2017

Fixed via 633de3e

@madeye madeye closed this as completed Jan 18, 2017
@Mygod
Copy link
Author

Mygod commented Jan 18, 2017

Great! The codebase looks much cleaner now.

@Mygod Mygod mentioned this issue Jan 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@madeye @Mygod