Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWC Support? #309

Open
alex-cory opened this issue Dec 29, 2021 · 7 comments
Open

SWC Support? #309

alex-cory opened this issue Dec 29, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@alex-cory
Copy link

alex-cory commented Dec 29, 2021

Summary

Are there any plans on upgrading to SWC?

@alex-cory alex-cory added the bug Something isn't working label Dec 29, 2021
@uncvrd
Copy link

uncvrd commented Jan 6, 2022

I imagine this would be considered once the feature is out of beta in NextJS, but also watching this as well!

@alex-cory
Copy link
Author

What do you mean out of beta? We're in Next 12 now and SWC support was introduced in Next 11.

@uncvrd
Copy link

uncvrd commented Jan 10, 2022

Because according to the docs, it's considered an Experimental feature: https://nextjs.org/docs/advanced-features/compiler#experimental-features

@shadowwalker shadowwalker added enhancement New feature or request and removed bug Something isn't working labels Apr 9, 2022
@AlbinoGeek
Copy link

AlbinoGeek commented Nov 24, 2022

Because according to the docs, it's considered an Experimental feature: https://nextjs.org/docs/advanced-features/compiler#experimental-features

Version Notes
v13.0.0 SWC Minifier enabled by default.
v12.3.0 SWC Minifier stable.
v12.2.0 SWC Plugins experimental support added.

We are still not using next-pwa in most of our apps because it doesn't support SWC and throws hundreds of yarn warnings about workbox, webpack, etc etc.

@pixelass
Copy link

pixelass commented Dec 1, 2022

I haven't experienced any blockers with next-pwa and SWC. The only packages that still request babel are cypress and the usual suspect: storybook.

In case you're interested in my setup: https://github.com/pixelass/pwa-template

@AlbinoGeek
Copy link

AlbinoGeek commented Dec 15, 2022

I haven't experienced any blockers with next-pwa and SWC. The only packages that still request babel are cypress and the usual suspect: storybook.

In case you're interested in my setup: https://github.com/pixelass/pwa-template

Cypress 😢 Have an alternative? We'd gladly switch 😀

@pixelass
Copy link

Cypress 😢 Have an alternative? We'd gladly switch 😀

Cypress has their own process so it shouldn't impact you in any way. Babel is not even listed in the dependencies of the example repo I posted. It will be installed by cypress and storybook if you are using either but there is zero impact on the rest of the project (AFAIK).

What I wanted to say is: "next-pwa does not have any noticable issues with SWC".

I'm not sure if this has changed since this issue was opened, but from my experience this is currently a non-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants