Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick-understanding with CSS #33

Closed
PandaWood opened this issue Jul 8, 2016 · 2 comments
Closed

Quick-understanding with CSS #33

PandaWood opened this issue Jul 8, 2016 · 2 comments

Comments

@PandaWood
Copy link

PandaWood commented Jul 8, 2016

Can I just suggest you make it clear on how to use this - when it comes to CSS.
It seems like, given all your examples, you have to get the html/css all setup (maybe 100 lines) before you can use this.

But you've written that this is your "preference" and that is all.

Is it because it won't work any other way or you just prefer to create examples like this?

Then looking at the examples, I have to study carefully to figure out what CSS is in your own library and what I need to introduce.

@shagstrom
Copy link
Owner

Ah ok, I thought it was pretty clear.

The example in the readme file is 48 lines, including html boilerplate stuff. Some stuff would be necessary regardless. For example this, since the plugin doesn't know which size the website author wants on the parent container - body doesn't need to be the parent container.

html, body {
    height: 100%;
    min-height: 100%;
    margin: 0;
    padding: 0;
}

Using css is the only way to set up the split pane, so I might need to make that clearer in the readme.

@shagstrom
Copy link
Owner

Readme is updated. Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants