Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should a Formatter be Used? #10

Closed
JammSpread opened this issue Feb 22, 2021 · 3 comments
Closed

Should a Formatter be Used? #10

JammSpread opened this issue Feb 22, 2021 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@JammSpread
Copy link

I wonder whether a formatter (such as Prettier) could help format the source code. It could also help maintain consistency throughout the project. Would that be useful and make sense in this project?

@shahednasser
Copy link
Owner

Hi @JammSpread Prettier is a good idea, however as this project doesn't rely or use NPM there's no place for it. One thing we can do though is add a GitHub action for Prettier I think it would work.

I am concerned for one thing though which is that a lot of the CSS is considered by compilers/linters as invalid since it uses Chrome's i18n variables, so I'm not sure if prettier would work properly with it.

@shahednasser shahednasser added enhancement New feature or request question Further information is requested labels Feb 22, 2021
@JammSpread
Copy link
Author

I was thinking about the action setup as well, however ".css" could always be ignored if it doesn't work out.

@shahednasser
Copy link
Owner

I think then prettier should be mostly applied to the javascript files main.js, options.js and background.js as the rest of the files are mostly minified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants