Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Hijri Date #11

Closed
mehdico opened this issue Aug 19, 2021 · 1 comment
Closed

Wrong Hijri Date #11

mehdico opened this issue Aug 19, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on

Comments

@mehdico
Copy link

mehdico commented Aug 19, 2021

Today is 19/8/2021 and 10 Muḥarram 1443 in IRDT or UTC +4:30, but the extension displays 11 Muḥarram 1443.
Maybe add a setting to fix the day of the month by +1 & -1 options, or update Hijri date from an online time provider.
@shahednasser
Copy link
Owner

Thank you @mehdico for the feedback. A previous version of this extension was using an online time provider, however, the same problem occurred as the Hijri date was different.

This is mainly due to different regions. For example, here in Lebanon, it's 11 Muharram. So, I think I need to find another way to get the date based on the user's location.

If you have any suggestions please let me know as well!

@shahednasser shahednasser added enhancement New feature or request help wanted Extra attention is needed labels Aug 19, 2021
@shahednasser shahednasser added the wontfix This will not be worked on label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mehdico @shahednasser