fix(trim): accuracy (#101)

shahen94 · Sep 24, 2017 · 41c9c54 · 41c9c54
1 parent 4b134a3
commit 41c9c54
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/android/src/main/java/com/shahenlibrary/Trimmer/Trimmer.java b/android/src/main/java/com/shahenlibrary/Trimmer/Trimmer.java
@@ -562,16 +562,22 @@ static void crop(String source, ReadableMap options, final Promise promise, Reac
     ArrayList<String> cmd = new ArrayList<String>();
     cmd.add("-y"); // NOTE: OVERWRITE OUTPUT FILE
 
+    // NOTE: INPUT FILE
+    cmd.add("-i");
+    cmd.add(source);
+
+    // NOTE: PLACE ARGUMENTS FOR FFMPEG IN THIS ORDER:
+    // 1. "-i" (INPUT FILE)
+    // 2. "-ss" (START TIME)
+    // 3. "-to" (END TIME) or "-t" (TRIM TIME)
+    // OTHERWISE WE WILL LOSE ACCURACY AND WILL GET WRONG CLIPPED VIDEO
+
     String startTime = options.getString("startTime");
     if ( !startTime.equals(null) && !startTime.equals("") ) {
       cmd.add("-ss");
       cmd.add(startTime);
     }
 
-    // NOTE: INPUT FILE
-    cmd.add("-i");
-    cmd.add(source);
-
     String endTime = options.getString("endTime");
     if ( !endTime.equals(null) && !endTime.equals("") ) {
       cmd.add("-to");