Skip to content

Commit

Permalink
feat(Trimmer): expose borderWidth prop
Browse files Browse the repository at this point in the history
  • Loading branch information
JBerendes committed Mar 15, 2017
1 parent b911ceb commit b2e148e
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 1 deletion.
16 changes: 16 additions & 0 deletions ios/RNVideoProcessing/RNTrimmerView/RNTrimmerView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class RNTrimmerView: RCTView, ICGVideoTrimmerDelegate {
var _minLength: CGFloat? = nil
var _maxLength: CGFloat? = nil
var _thumbWidth: CGFloat? = nil
var _borderWidth: CGFloat? = nil
var _trackerColor: UIColor = UIColor.clear

var source: NSString? {
Expand Down Expand Up @@ -100,6 +101,18 @@ class RNTrimmerView: RCTView, ICGVideoTrimmerDelegate {
}
}

var borderWidth: NSNumber? {
set {
if newValue != nil {
self._borderWidth = RCTConvert.cgFloat(newValue!)
self.updateView()
}
}
get {
return nil
}
}

var currentTime: NSNumber? {
set {
print("CHANGED: [TrimmerView]: currentTime: \(newValue)")
Expand Down Expand Up @@ -147,6 +160,9 @@ class RNTrimmerView: RCTView, ICGVideoTrimmerDelegate {
if _thumbWidth != nil {
trimmerView!.thumbWidth = _thumbWidth!
}
if _borderWidth != nil {
trimmerView!.borderWidth = _borderWidth!
}
self.trimmerView!.resetSubviews()
// Timer.scheduledTimer(timeInterval: 0.5, target: self, selector: #selector(self.updateTrimmer), userInfo: nil, repeats: false)
}
Expand Down
1 change: 1 addition & 0 deletions ios/RNVideoProcessing/RNTrimmerView/RNTrimmerViewBridge.m
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@ @interface RCT_EXTERN_MODULE(RNTrimmerViewManager, RCTViewManager)
RCT_EXPORT_VIEW_PROPERTY(currentTime, NSNumber)
RCT_EXPORT_VIEW_PROPERTY(trackerColor, NSString)
RCT_EXPORT_VIEW_PROPERTY(thumbWidth, NSNumber)
RCT_EXPORT_VIEW_PROPERTY(borderWidth, NSNumber)

@end
5 changes: 4 additions & 1 deletion lib/Trimmer/Trimmer.ios.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ export class Trimmer extends Component {
maxLength: PropTypes.number,
currentTime: PropTypes.number,
trackerColor: PropTypes.string,
thumbWidth: PropTypes.number
thumbWidth: PropTypes.number,
borderWidth: PropTypes.number,
};

static defaultProps = {
Expand Down Expand Up @@ -56,6 +57,7 @@ export class Trimmer extends Component {
currentTime,
trackerColor,
thumbWidth,
borderWidth,
} = this.props;
const actualSource = getActualSource(source);
return (
Expand All @@ -72,6 +74,7 @@ export class Trimmer extends Component {
minLength={minLength}
maxLength={maxLength}
thumbWidth={thumbWidth}
borderWidth={borderWidth}
/>
);
}
Expand Down

0 comments on commit b2e148e

Please sign in to comment.